feat: add first-party Tinybird analytics#2003
Open
richiemcilroy wants to merge 16 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![superagent-security[bot]](https://avatars.githubusercontent.com/in/3287076?s=60&v=4){kind=small}
superagent-security
Bot
added
the
pr:flagged
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
superagent-security
Bot
removed
the
pr:flagged
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
superagent-security
Bot
added
the
pr:flagged
superagent-security
Bot
removed
the
pr:flagged
Member
Author
|
hey @greptileai, please re-review the PR |
superagent-security
Bot
added
pr:flagged
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
superagent-security
Bot
added
the
pr:flagged
Member
Author
|
hey @greptileai, please re-review the PR |
superagent-security
Bot
removed
the
pr:flagged
Comment on lines
+92
to
+100
| const browserClaims = | ||
| hasExpectedBrowserAnalyticsMetadata( | ||
| requestMetadata, | ||
| allowedOrigins, | ||
| ) && | ||
| readProductAnalyticsBrowserTokenClaims( | ||
| readProductAnalyticsBrowserToken(headers.cookie), | ||
| serverEnv().NEXTAUTH_SECRET, | ||
| ); |
There was a problem hiding this comment.
Minor robustness nit: if token claim parsing throws (bad secret, malformed cookie, etc) this will currently 500. I'd rather treat that as “no browser claims” and let it fall through to the normal BadRequest path.
Suggested change
| const browserClaims = | |
| hasExpectedBrowserAnalyticsMetadata( | |
| requestMetadata, | |
| allowedOrigins, | |
| ) && | |
| readProductAnalyticsBrowserTokenClaims( | |
| readProductAnalyticsBrowserToken(headers.cookie), | |
| serverEnv().NEXTAUTH_SECRET, | |
| ); | |
| let browserClaims; | |
| if ( | |
| hasExpectedBrowserAnalyticsMetadata( | |
| requestMetadata, | |
| allowedOrigins, | |
| ) | |
| ) { | |
| try { | |
| browserClaims = readProductAnalyticsBrowserTokenClaims( | |
| readProductAnalyticsBrowserToken(headers.cookie), | |
| serverEnv().NEXTAUTH_SECRET, | |
| ); | |
| } catch { | |
| browserClaims = undefined; | |
| } | |
| } |
Comment on lines
+432
to
+434
| if (result.error || result.status !== 0) { | ||
| throw new Error("Unable to verify Tinybird workspace identity."); | ||
| } |
There was a problem hiding this comment.
This failure path drops the actual stderr/stdout, which makes CI deploy debugging pretty painful. I’d include stderr (trimmed) in the thrown error message.
Suggested change
| if (result.error || result.status !== 0) { | |
| throw new Error("Unable to verify Tinybird workspace identity."); | |
| } | |
| if (result.error || result.status !== 0) { | |
| const stderr = (result.stderr ?? "").toString().trim(); | |
| throw new Error( | |
| stderr | |
| ? `Unable to verify Tinybird workspace identity: ${stderr}` | |
| : "Unable to verify Tinybird workspace identity.", | |
| ); | |
| } |
richiemcilroy
force-pushed
the
codex/first-party-analytics
branch
from
a9b199c to
fee7c3a
Compare
| { | ||
| eventId, | ||
| eventName: event.eventName, | ||
| occurredAt: event.occurredAt ?? new Date().toISOString(), |
There was a problem hiding this comment.
Small robustness thing: occurredAt is passed through as-is, so a bad caller value will land as a bad timestamp in Tinybird. Might be worth normalizing/validating and falling back to now.
Suggested change
| occurredAt: event.occurredAt ?? new Date().toISOString(), | |
| occurredAt: | |
| event.occurredAt && Number.isFinite(Date.parse(event.occurredAt)) | |
| ? new Date(event.occurredAt).toISOString() | |
| : new Date().toISOString(), |
Comment on lines
+49
to
+55
| const client = new PostHog(key, { host }); | ||
| client.capture({ | ||
| distinctId: event.distinctId, | ||
| event: event.eventName, | ||
| properties: event.properties, | ||
| }); | ||
| await client.shutdown(); |
There was a problem hiding this comment.
Minor cleanup: if client.capture throws, shutdown() won’t run. I’d wrap shutdown in a finally.
Suggested change
| const client = new PostHog(key, { host }); | |
| client.capture({ | |
| distinctId: event.distinctId, | |
| event: event.eventName, | |
| properties: event.properties, | |
| }); | |
| await client.shutdown(); | |
| const client = new PostHog(key, { host }); | |
| try { | |
| client.capture({ | |
| distinctId: event.distinctId, | |
| event: event.eventName, | |
| properties: event.properties, | |
| }); | |
| } finally { | |
| await client.shutdown(); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm analytics:test— 146 tests passedpnpm typecheckcargo fmt --all -- --checkcargo check -p cap-desktopcargo test -p cap-desktop posthog --lib— 11 tests passedRollout gate
Explicit PostHog dual-write remains until 14 days of parity and a durable purchase outbox/replay path exist. Tinybird Local runtime build and fixture execution are delegated to this PR's analytics workflow.
Greptile Summary
This PR adds first-party Tinybird product analytics across web, desktop, and deployment tooling. The main changes are:
/api/eventsingestion path for bounded client analytics.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (9): Last reviewed commit: "fix: parse Tinybird workspace identity" | Re-trigger Greptile
Context used: